Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17983 )
Change subject: IMPALA-10920: Zipping unnest for arrays ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/17983/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/17983/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@883 PS6, Line 883: az > typo Done http://gerrit.cloudera.org:8080/#/c/17983/6/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/17983/6/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2179 PS6, Line 2179: collectionRefs > nit: add zipping to the name, e.g. collectionRefsToZip? Done http://gerrit.cloudera.org:8080/#/c/17983/6/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/17983/6/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test@166 PS6, Line 166: AnalysisException: Providing zipping unnest both in the SELECT list and in the FROM clause is not supported. > Can you add a test where we try to unnest an array nested within an array? Added some extra negative tests around this. One will might start working once you put your "array in select list" on top of this patch. -- To view, visit http://gerrit.cloudera.org:8080/17983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic58ff6579ecff03962e7a8698edfbe0684ce6cf7 Gerrit-Change-Number: 17983 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 18 Nov 2021 22:00:54 +0000 Gerrit-HasComments: Yes
