Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18042 )
Change subject: IMPALA-11031: Listmap.getIndex() name is misleading ...................................................................... IMPALA-11031: Listmap.getIndex() name is misleading Listmap.getIndex(t) modifies the ListMap object when there is no mapping for 't'. Hence the name of it is very misleading as the reader wouldn't expect modifications from simple getters. This patch renames it to getOrAddIndex(). Change-Id: I689dfb67e1a9104812489d6299ed43446d2fcae8 Reviewed-on: http://gerrit.cloudera.org:8080/18042 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java M fe/src/main/java/org/apache/impala/catalog/HdfsPartitionLocationCompressor.java M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/util/ListMap.java 7 files changed, 11 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I689dfb67e1a9104812489d6299ed43446d2fcae8 Gerrit-Change-Number: 18042 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
