Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18038 )
Change subject: IMPALA-11028: Table loading can fail when events are cleaned up ...................................................................... Patch Set 15: Code-Review+2 (4 comments) Carrying forward Aman's +2 from earlier. There were mostly formatting changes and a new test file added since that last +2. http://gerrit.cloudera.org:8080/#/c/18038/8/fe/src/main/java/org/apache/impala/catalog/TableLoader.java File fe/src/main/java/org/apache/impala/catalog/TableLoader.java: http://gerrit.cloudera.org:8080/#/c/18038/8/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@86 PS8, Line 86: events = MetastoreEventsProcessor.getNextMetastoreEventsInBatches(catalog_, > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/18038/8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/18038/8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@305 PS8, Line 305: @Test > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/18038/11/tests/custom_cluster/test_metastore_events_cleanup.py File tests/custom_cluster/test_metastore_events_cleanup.py: http://gerrit.cloudera.org:8080/#/c/18038/11/tests/custom_cluster/test_metastore_events_cleanup.py@24 PS11, Line 24: > flake8: E501 line too long (95 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/18038/11/tests/custom_cluster/test_metastore_events_cleanup.py@26 PS11, Line 26: > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/18038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95e5e20e1a2086688a92abdfb28e89177e996a1a Gerrit-Change-Number: 18038 Gerrit-PatchSet: 15 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 23 Nov 2021 01:34:22 +0000 Gerrit-HasComments: Yes
