Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 )
Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18048/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/18048/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@396 PS1, Line 396: "X-Forwarded-For" nit: maybe just add a separate simple test like Case2 above (mentioning that it checks specifically for case-insensitivity) to make it obvious what we are testing -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 23 Nov 2021 21:04:57 +0000 Gerrit-HasComments: Yes
