Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )
Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0 ...................................................................... Patch Set 3: Hi Qifan, This looks good to me. Can we add e2e test to check we're not hitting this issue again? I happen to file different patch at https://gerrit.cloudera.org/c/18069/. I add one test there in overlap_min_max_filters.test. Would be great to add it here if it is make sense. I will abandon my change and we should go ahead with yours. -- To view, visit http://gerrit.cloudera.org:8080/18071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e Gerrit-Change-Number: 18071 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sun, 05 Dec 2021 16:55:43 +0000 Gerrit-HasComments: No
