Qifan Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18050 )

Change subject: [WIP] IMPALA-10992 Planner changes for estimate peak memory - v2
......................................................................


Patch Set 11:

Resolved the following.

P9:

+-----------------------------------------------------------------------------------+
| Explain String                                                                
    |
+-----------------------------------------------------------------------------------+
| Max Per-Host Resource Reservation: Memory=12.03MB Threads=2                   
    |
| Per-Host Resource Estimates: Memory=140MB                                     
    |
| Codegen disabled by planner                                                   
    |
|                                                                               
    |
| WRITE TO HDFS [functional.alltypes, OVERWRITE=false, 
PARTITION-KEYS=(year,month)] |
| |  partitions=24                                                              
    |
| |                                                                             
    |
| 02:SORT                                                                       
    |.   <=== should be 01. (resolved)
| |  order by: year ASC NULLS LAST, month ASC NULLS LAST                        
    |
| |  row-size=89B cardinality=7.30K                                             
    |
| |                                                                             
    |
| 00:SCAN HDFS [functional.alltypes]                                            
    |
|    HDFS partitions=24/24 files=24 size=478.45KB                               
    |
|    row-size=89B cardinality=7.30K                                             
    |
+—————————————————————————————————————————



P10:

explain
insert into table functional.alltypes partition(year, month)
select * from functional.alltypes;

59 Error Stack:                               
   60 java.lang.IndexOutOfBoundsException: toIndex = 11                        
<=== resolved:   via  copy resultExpr in InsertStmt , which is an extra  deep 
copied data members  in InsertStmt.cstr().  It is not a good idea to share 
AnalysisResults_ in PlannerContext as the stuff is modified.
   61   at java.util.ArrayList.subListRangeCheck(ArrayList.java:1014)           
 
   62   at java.util.ArrayList.subList(ArrayList.java:1006)
   63   at 
org.apache.impala.planner.HdfsTableSink.collectExprs(HdfsTableSink.java:345)   
   64   at 
org.apache.impala.planner.Planner.createPlanFragments(Planner.java:283)
   65   at org.apache.impala.planner.Planner.createPlans(Planner.java:303)      
               
   66   at 
org.apache.impala.service.Frontend.createExecRequest(Frontend.java:1562)


--
To view, visit http://gerrit.cloudera.org:8080/18050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8a31a574b364f39b049a4bae33a8b98c5fc20bd
Gerrit-Change-Number: 18050
Gerrit-PatchSet: 11
Gerrit-Owner: Qifan Chen <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Comment-Date: Tue, 07 Dec 2021 21:38:36 +0000
Gerrit-HasComments: No

Reply via email to