Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18078 )
Change subject: IMPALA-11054: Support resource pool polling for frontend ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18078/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18078/2//COMMIT_MSG@9 PS2, Line 9: To support different sizes of resource pools, Planner will need to poll : resource pool which is only done by backend currently. nit: can remove this context since its not relevant to the patch directly http://gerrit.cloudera.org:8080/#/c/18078/2/fe/src/main/java/org/apache/impala/util/RequestPoolService.java File fe/src/main/java/org/apache/impala/util/RequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/18078/2/fe/src/main/java/org/apache/impala/util/RequestPoolService.java@345 PS2, Line 345: if (LOG.isTraceEnabled()) { : LOG.trace("resolveRequestPool(pool={}, user={}): resolved_pool={}, has_access={}", : resolvePoolParams.getRequested_pool(), resolvePoolParams.getUser(), : result.resolved_pool, result.has_access); : } maybe log this at the end right before return so that its logged in all cases and not only when there is a successful resolution. (similar to how it was logged every time before this patch/0 -- To view, visit http://gerrit.cloudera.org:8080/18078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia78b1a0574f6b8ad4df5bb0fc9533f218b486e6b Gerrit-Change-Number: 18078 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Mon, 13 Dec 2021 17:41:56 +0000 Gerrit-HasComments: Yes
