Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 )
Change subject: IMPALA-9498: Allow returning arrays in select list ...................................................................... Patch Set 28: (9 comments) http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1395 PS28, Line 1395: Preconditions.checkState(rootDesc != null); nit: Preconditions.checkNotNull(rootDesc); http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1408 PS28, Line 1408: Preconditions.checkState(collTblRef.getCollectionExpr() != null); nit: this is covered by the check at next line so can be removed. https://stackoverflow.com/questions/2950319/is-null-check-needed-before-calling-instanceof http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1414 PS28, Line 1414: List<String> rawPathToItem = new ArrayList<String>(); : rawPathToItem.add("item"); nit: we can use Lists.newArrayList("item") and make it a constant. http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1429 PS28, Line 1429: this. nit: don't need 'this' http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1430 PS28, Line 1430: slotDesc.setStats(new ColumnStats(slotDesc.getType())); Should we only add stats for primitive types? http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java File fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java: http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@67 PS28, Line 67: String.join(".", rawPath_) I think we should convert this to lower case as well. http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@198 PS28, Line 198: public void analyze(Analyzer analyzer) throws AnalysisException { This method is too long now. Can we extract some codes into methods? http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@277 PS28, Line 277: Preconditions.checkState(colExpr.getType().isArrayType()); nit: this is the same as the if-clause so we can remove it. http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@286 PS28, Line 286: immidiate typo: immediate -- To view, visit http://gerrit.cloudera.org:8080/17811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e42ffb21c7ddc033aba0f754b0108e46f34d0 Gerrit-Change-Number: 17811 Gerrit-PatchSet: 28 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 22 Dec 2021 06:28:21 +0000 Gerrit-HasComments: Yes
