Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 )
Change subject: IMPALA-11033: Add support for specifying multiple executor group sets ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.cc@622 PS5, Line 622: DCHECK(!prefix.empty() || exec_group_sets.size() == 1) > exec_group_sets.size() == 1 is there to ensure that if prefix is empty then Thanks http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.cc@629 PS5, Line 629: if (!it.second.IsHealthy()) continue; > if a group is not healthy it, we have visibility over it as it will show up Thanks -- To view, visit http://gerrit.cloudera.org:8080/18093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e0a3a5fe2b1f0b7507b7c096b7a3c373bc2e684 Gerrit-Change-Number: 18093 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 22 Dec 2021 16:43:02 +0000 Gerrit-HasComments: Yes
