Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18113 )
Change subject: IMPALA-10436: Require lower privilege for external Kudu table creation ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/18113/1/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java File fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java: http://gerrit.cloudera.org:8080/#/c/18113/1/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java@112 PS1, Line 112: public static PrivilegeSpec createStorageHandlerUriScopedPriv(TPrivilegeLevel privilegeLevel, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18113/1/fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java File fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java: http://gerrit.cloudera.org:8080/#/c/18113/1/fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java@69 PS1, Line 69: public PrivilegeRequestBuilder onStorageHandlerUri(String storageType, String storageUri) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/18113/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: http://gerrit.cloudera.org:8080/#/c/18113/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1735 PS1, Line 1735: testToSql(ctx, String.format("GRANT RWSTORAGE ON STORAGEHANDLER_URI '%s' TO %s %s", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/18113/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/18113/1/tests/authorization/test_ranger.py@341 PS1, Line 341: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/18113/1/tests/authorization/test_ranger.py@372 PS1, Line 372: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/18113/1/tests/authorization/test_ranger.py@387 PS1, Line 387: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/18113/1/tests/authorization/test_ranger.py@544 PS1, Line 544: flake8: E241 multiple spaces after ',' -- To view, visit http://gerrit.cloudera.org:8080/18113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e2312f85e3a3b0a081d2f935fcf5edd020bd928 Gerrit-Change-Number: 18113 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Dec 2021 20:14:31 +0000 Gerrit-HasComments: Yes
