Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class. ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/impala_test_suite.py@692 PS1, Line 692: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/impala_test_suite.py@744 PS1, Line 744: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py File tests/common/test_section.py: http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@27 PS1, Line 27: class TestSection(object): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@57 PS1, Line 57: , flake8: W602 deprecated form of raising exception http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@71 PS1, Line 71: , flake8: W602 deprecated form of raising exception http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@75 PS1, Line 75: = flake8: E711 comparison to None should be 'if cond is None:' http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@80 PS1, Line 80: , flake8: W602 deprecated form of raising exception http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@93 PS1, Line 93: , flake8: W602 deprecated form of raising exception http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@107 PS1, Line 107: , flake8: W602 deprecated form of raising exception http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@111 PS1, Line 111: , flake8: W602 deprecated form of raising exception http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@128 PS1, Line 128: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@128 PS1, Line 128: return default_val line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@139 PS1, Line 139: def test_section_create(section_text, valid_section_names=None, skip_unknown_sections=False): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@139 PS1, Line 139: e flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/18119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd Gerrit-Change-Number: 18119 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 05 Jan 2022 00:35:40 +0000 Gerrit-HasComments: Yes
