Hello Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18120
to look at the new patch set (#2).
Change subject: IMPALA-10951 (preparation): Update Kudu to a more recent version
......................................................................
IMPALA-10951 (preparation): Update Kudu to a more recent version
Kudu has fixed IMPALA-3334, where some protobuf symbols were
being exposed in the Kudu client and causing conflicts when
Impala upgrades protobuf. This updates Kudu to pull in that fix.
As a part of updating Kudu, building with Clang failed at link
time with this error:
libprotobuf.a(dynamic_message.o):dynamic_message.cc:function
google::protobuf::DynamicMessage::~DynamicMessage(): warning: relocation refers
to discarded section
Newer versions of binutils provide a better error message:
TargetPassConfig.cpp:function llvm::TargetPassConfig::createRegAllocPass(bool):
error: relocation refers to global symbol "std::call_once<void
(&)()>(std::once_flag&, void (&)())::{lambda()#2}::_FUN()", which is defined in
a discarded section
section group signature:
"_ZZSt9call_onceIRFvvEJEEvRSt9once_flagOT_DpOT0_ENKUlvE0_clEv"
prevailing definition is from
../../build/debug/security/libsecurity.a(openssl_util.cc.o)
(Bumping the binutils version will happen in a separate change.)
This also adds the calloncehack component, which builds a shared
library with the missing symbol. When this shared library is linked
ahead of kudu_client, it provides the missing symbol and
avoids the issue.
Change-Id: If551dbd4454221e8a5c485c5e24cfad2eaa5f2a7
---
M buildall.sh
A source/calloncehack/build.sh
A source/calloncehack/calloncehack/CMakeLists.txt
A source/calloncehack/calloncehack/calloncehack.cc
A source/calloncehack/calloncehack/calloncehack.h
5 files changed, 163 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain
refs/changes/20/18120/2
--
To view, visit http://gerrit.cloudera.org:8080/18120
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If551dbd4454221e8a5c485c5e24cfad2eaa5f2a7
Gerrit-Change-Number: 18120
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
