Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18123 )
Change subject: [WIP] IMPALA-10992 Planner changes for estimate peak memory - v3 ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18123/5/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/18123/5/common/thrift/Frontend.thrift@721 PS5, Line 721: query_size_threshold What's the unit for query size? http://gerrit.cloudera.org:8080/#/c/18123/5/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/18123/5/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@260 PS5, Line 260: sinks are added Need to update the comments. -- To view, visit http://gerrit.cloudera.org:8080/18123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8e1776ffef3948c9d5fbf895fb4a19317e43502 Gerrit-Change-Number: 18123 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 06 Jan 2022 23:38:23 +0000 Gerrit-HasComments: Yes
