Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18128 )
Change subject: IMPALA-11043: [DOCS] Initial Iceberg documentation ...................................................................... Patch Set 3: Code-Review+2 (7 comments) LGTM! Marked some nits, mainly some keywords that feels code snippets in the text. http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml@79 PS3, Line 79: you need not : rewrite nit: you don't need to rewrite http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml@188 PS3, Line 188: EXTERNAL nit: <codeph> http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml@339 PS3, Line 339: ALTER TABLE ... RENAME TO ... nit: <codeph> http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml@494 PS3, Line 494: COMPRESSION_CODEC nit: <codeph> http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml@499 PS3, Line 499: COMPRESSION_CODEC nit: <codeph> http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml@504 PS3, Line 504: PARQUET_FILE_SIZE nit: <codeph> http://gerrit.cloudera.org:8080/#/c/18128/3/docs/topics/impala_iceberg.xml@505 PS3, Line 505: PARQUET_FILE_SIZE nit: <codeph> -- To view, visit http://gerrit.cloudera.org:8080/18128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief452611319f31d660838d35414bada387a05ef7 Gerrit-Change-Number: 18128 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 10 Jan 2022 08:27:58 +0000 Gerrit-HasComments: Yes
