Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18125 )
Change subject: IMPALA-11070: Create TestSection class. ...................................................................... Patch Set 4: Perhaps I'm not familiar with python enough, but I essentially tried to do #2. But instead of [], I'm using get_section(). Are you saying there's a way you can override the [] operator? Sounds a bit overkill, but I'm willing to try it that way. But really, my thought was that there is a lot of test_section code that really should eventually be moved and placed into a class. There are some "replace" and "setter" operations where the code is in the client but should be in a test_section class, and I suppose that's where my thought came from that it should be a class, something a little more heavy than just a dictionary. Also, I'm finding that my extension is doing some tricky operations as well. A class just feels a bit more natural for me. Do you find the new code too cumbersome? To me, it does seem very natural to fetch things off of a TestSection object, but again, as I mentioned, I've been doing most of my coding in Java (and C++ to, but I don't particular like operator overloads unless absolutely necessary). -- To view, visit http://gerrit.cloudera.org:8080/18125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fed7ef64ac263b49b5b6e4a237a296092e4dcb8 Gerrit-Change-Number: 18125 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 13 Jan 2022 00:36:19 +0000 Gerrit-HasComments: No
