Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18142 )
Change subject: IMPALA-11063: Add metrics to expose state of each executor group set ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.h@248 PS1, Line 248: aggregated_group_set_m > nit. May name it as overall_group_set_metrics_ to keep it consistent with p Done http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@64 PS1, Line 64: static const string LIVE_EXEC_GROUP_KEY_FORMAT( > Nit: This is not incorrect, but "cluster-membership.executor-groups.total.$ Done http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@89 PS1, Line 89: MetricGroup* metric_grp = metrics->GetOrCreateChildGroup("cluster-membership"); : aggregated_group_set_metrics_.total_live_executor_groups_ = : metric_grp->AddCounter(LIVE_EXEC_GROUP_KEY, 0); : aggregated_group_set_metrics_.total_healthy_executor_groups_ = : metric_grp->AddCounter(HEALTHY_EXEC_GROUP_KEY, 0); > nit.these lines of code can be moved to a method GroupSetMetrics::Add(Metri The keys and inputs to AddCounter() are different for 'overall' vs 'per_group_set' so the special casing for both would end up with the same structure as InitMetrics() here. http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@606 PS1, Line 606: ngPiece name(grou > I wonder if there is a method ExecutorGroup::isLive(). If so, it can be use group.NumHosts() > 0 is the only simple check we need unlike IsHealthy() which needs to know the 'min_size' of the exec group as well (where 'min size' is the minimum number of executors in the group to be considered healthy) http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@611 PS1, Line 611: : if (group.NumHosts() > 0) { > nit. duplicated lines with the THEN branch. Good point. Done. http://gerrit.cloudera.org:8080/#/c/18142/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/18142/1/tests/custom_cluster/test_executor_groups.py@134 PS1, Line 134: metric_name = "cluster-membership.executor-groups.total" > This is where the code I marked with a Nit is actually useful Done http://gerrit.cloudera.org:8080/#/c/18142/1/tests/custom_cluster/test_executor_groups.py@685 PS1, Line 685: c > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/18142/1/tests/custom_cluster/test_executor_groups.py@694 PS1, Line 694: _ > flake8: E251 unexpected spaces around keyword / parameter equals Done -- To view, visit http://gerrit.cloudera.org:8080/18142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39f940de830ef6302785aee30eeb847fa5deeba Gerrit-Change-Number: 18142 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 13 Jan 2022 01:31:03 +0000 Gerrit-HasComments: Yes
