Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18020 )
Change subject: IMPALA-10997: Refactor Java Hive UDF code. ...................................................................... Patch Set 12: Code-Review+1 (4 comments) Thanks, +1 for my part after these few comments are addressed. Csaba said he also wanted to take a look so I'll wait with +2. http://gerrit.cloudera.org:8080/#/c/18020/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18020/12//COMMIT_MSG@10 PS12, Line 10: Nit: Trailing whitespace. http://gerrit.cloudera.org:8080/#/c/18020/12//COMMIT_MSG@30 PS12, Line 30: HiveJavaClass This has been renamed to HiveUdfLoader http://gerrit.cloudera.org:8080/#/c/18020/12/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18020/12/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@141 PS12, Line 141: dependentclasses Nit: dependent classes. http://gerrit.cloudera.org:8080/#/c/18020/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18020/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4087 PS10, Line 4087: > It should be needed, right? Otherwise it will show up as "orwere" Yes, I also meant there should be a space... Strange, I thought the space had been deleted, that's why I wrote the comment... Either I overlooked something or this was also some strange thing with the rebase. -- To view, visit http://gerrit.cloudera.org:8080/18020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc9572e15fbed1876412159b99dddd3fb4d37174 Gerrit-Change-Number: 18020 Gerrit-PatchSet: 12 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 26 Jan 2022 22:23:54 +0000 Gerrit-HasComments: Yes
