Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18080 )
Change subject: IMPALA-11056: Create option to fail query on Java UDF exceptions ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call-ir.cc File be/src/exprs/hive-udf-call-ir.cc: http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call-ir.cc@71 PS3, Line 71: } > Same comment as above. Done http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call.cc@122 PS3, Line 122: } > Could you move the closing brace after the warning_logged = true statement Done http://gerrit.cloudera.org:8080/#/c/18080/3/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/18080/3/common/thrift/Query.thrift@571 PS3, Line 571: (legacy) > nit: remove 'legacy' since that may be misinterpreted. Done http://gerrit.cloudera.org:8080/#/c/18080/3/common/thrift/Query.thrift@571 PS3, Line 571: java udf > nit: 'Java UDF' for consistency with how it is worded later in this comment Done -- To view, visit http://gerrit.cloudera.org:8080/18080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece20cf16a6575f1c498238f754440e870e2ce9 Gerrit-Change-Number: 18080 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 26 Jan 2022 23:01:44 +0000 Gerrit-HasComments: Yes
