Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18160 )
Change subject: IMPALA-11076: Re-use FDs loaded by HdfsTable during IcebergTable load ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18160/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18160/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@529 PS2, Line 529: } > We should raise an error/warning when we don't find a file. Or maybe we cou Agree, this case should be handled, do you think a TableLoadingException would be reasonable as well? The query would be aborted and the table would be incomplete. -- To view, visit http://gerrit.cloudera.org:8080/18160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id49daec60237dd6c8cce92c00a09fd9a6e6479b4 Gerrit-Change-Number: 18160 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 28 Jan 2022 10:09:50 +0000 Gerrit-HasComments: Yes
