Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18177/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18177/1//COMMIT_MSG@10 PS1, Line 10: The periodic callback is now disabled. I would prefer a solution where we would return some warning/error to the users when they use both live progress and hs2_strict instead of disabling this feature silently. The live progress feature is not very useful without returning any live progress info :) http://gerrit.cloudera.org:8080/#/c/18177/1//COMMIT_MSG@14 PS1, Line 14: Delaying the compile doesn't help (pre-execute) and adding a : "select sleep(<x>)" doesn't help either (done at fetch time). I think that there are several ways to add this kind of test - you could add sleep to another part of the query, or probably there is a debug_action that could introduce the sleep at the right place. Note that this wouldn't be needed if we returned an error as mentioned at line 10. -- To view, visit http://gerrit.cloudera.org:8080/18177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f Gerrit-Change-Number: 18177 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 31 Jan 2022 11:52:08 +0000 Gerrit-HasComments: Yes
