Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )
Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0 ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18071/8/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/18071/8/fe/src/main/java/org/apache/impala/planner/Planner.java@685 PS8, Line 685: if (queryOptions.getMinmax_filter_threshold() == 0.0) { > Do we need to check for negative values here? We should be fine. The BE limits the domain of the threshold values to [0.0, 1.0]. 414 case TImpalaQueryOptions::MINMAX_FILTER_THRESHOLD: { 415 StringParser::ParseResult status; 416 double val = StringParser::StringToFloat<double>( 417 value.c_str(), static_cast<int>(value.size()), &status); 418 if (status != StringParser::PARSE_SUCCESS || val < 0.0 || val > 1.0) { 419 return Status( 420 Substitute("Invalid minmax filter threshold '$0'. Valid sizes are in" 421 "[0.0, 1.0]", 422 value)); 423 } 424 query_options->__set_minmax_filter_threshold(val); 425 break; -- To view, visit http://gerrit.cloudera.org:8080/18071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e Gerrit-Change-Number: 18071 Gerrit-PatchSet: 8 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 01 Feb 2022 13:38:53 +0000 Gerrit-HasComments: Yes
