Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18212 )
Change subject: IMPALA-10989: fix race for result set metadata ...................................................................... IMPALA-10989: fix race for result set metadata TSAN tests uncovered a race condition between the thread reading the result set metadata in ImpalaServer::GetResultSetMetadata() and the thread setting the result set metadata in ClientRequestState::SetResultSet() from ClientRequestState::ExecDdlRequestImpl(). This is introduced by IMPALA-10811, which runs ExecDdlRequestImpl in an async thread that can now race with the client thread. GetResultSetMetadata() holds ClientRequestState's lock_ while reading the result set metadata, so the fix is to hold this lock when writing the result set metadata. Testing: - Ran TSAN core job Change-Id: Ic0833ed20d62474c434fa94bbbf8cd8ea99a7cf4 Reviewed-on: http://gerrit.cloudera.org:8080/18212 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> --- M be/src/service/client-request-state.cc 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic0833ed20d62474c434fa94bbbf8cd8ea99a7cf4 Gerrit-Change-Number: 18212 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]>
