Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18219 )
Change subject: WIP IMPALA-11064 Optimizing Temporary File Structure for Batch Reading ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/18219/1/be/src/runtime/tmp-file-mgr-internal.h File be/src/runtime/tmp-file-mgr-internal.h: http://gerrit.cloudera.org:8080/#/c/18219/1/be/src/runtime/tmp-file-mgr-internal.h@324 PS1, Line 324: const std::string& path, const std::string& local_buffer_path, const char* url = nullptr, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18219/1/be/src/runtime/tmp-file-mgr-internal.h@468 PS1, Line 468: /// Try to allocate the space from a new block in the file. If no new block is allowed in line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/18219/1/be/src/runtime/tmp-file-mgr-internal.h@473 PS1, Line 473: /// Set the actual bytes of the content, the bytes exclude the holes between blocks or at line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/18219/1/be/src/runtime/tmp-file-mgr-internal.h@476 PS1, Line 476: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18219/1/be/src/runtime/tmp-file-mgr-internal.h@556 PS1, Line 556: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/18219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If913785cac9e2dafa20013b6600c87fcaf3e2018 Gerrit-Change-Number: 18219 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 10 Feb 2022 01:50:01 +0000 Gerrit-HasComments: Yes
