Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18155 )
Change subject: WIP IMPALA-10931 (part2): Fixed rebased Kudu source to compile ...................................................................... WIP IMPALA-10931 (part2): Fixed rebased Kudu source to compile This patch applies various fixes to Impala and to the copied Kudu source code in be/src/kudu/* to allow everything to compile and pass Impala exhaustive tests. Highlights of the changes made: - Some flags that have a DEFINE in both Kudu and Impala are modified to change one of the DEFINEs to a DECLARE. - Fixed backend unit-test bloom-filter-test.cc due to the changes for block bloom filter false positive rate correction in kudu/util/block_bloom_filter.cc. - kudu::Sockaddr was changed to support different families of address. The storage of address is not cleaned in new constructor. This cause the padding bytes in IPv4 address sockaddr_in is not cleaned. We have to set initial values of Sockaddr variables as Sockaddr::Wildcard() as workaround. - The parameter type of kudu::RpcSidecar::FromFaststring() was changed, need to change the caller code in Impala. - openssl_util.h was moved from directory kudu/security to kudu/util. need to change including path in Impala. - TODO: Fix backend unit-test rpc-mgr-kerberized-test.cc This patch was in part based on the patches that were applied the last time we rebased the Kudu code in IMPALA-9335. All changes from those commits that are still relevant were included here. Went through all commits that have been applied to the be/src/kudu directory since the last rebase and ensured that all relevant changes from those are included here. These include patches for IMPALA-9182, IMPALA-10779, IMPALA-9940 and commit d9a38c0bac (Limit short versions of KUDU_* macros to Kudu source). Testing: - Passed core debug build, core ASAN build and exhaustive release build except one backend test rpc-mgr-kerberized-test. Change-Id: Ia9919c06e60d132d997093abb7b14825847e07c7 --- M be/src/kudu/rpc/CMakeLists.txt M be/src/kudu/rpc/transfer.cc M be/src/kudu/security/CMakeLists.txt M be/src/kudu/security/init.cc M be/src/kudu/security/test/mini_kdc.cc M be/src/kudu/security/tls_handshake.cc M be/src/kudu/util/CMakeLists.txt M be/src/kudu/util/flags.cc A be/src/kudu/util/kudu_export.h M be/src/kudu/util/logging.cc M be/src/kudu/util/logging.h M be/src/kudu/util/random_util.h M be/src/kudu/util/web_callback_registry.h M be/src/rpc/authentication-util.cc M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/rpc-mgr.cc M be/src/rpc/rpc-mgr.inline.h M be/src/rpc/sidecar-util.h M be/src/rpc/thrift-server.cc M be/src/runtime/query-state.cc M be/src/util/bloom-filter-test.cc M be/src/util/webserver.cc 23 files changed, 219 insertions(+), 81 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/18155/3 -- To view, visit http://gerrit.cloudera.org:8080/18155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia9919c06e60d132d997093abb7b14825847e07c7 Gerrit-Change-Number: 18155 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]>
