Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18184 )
Change subject: IMPALA-10961: Implementing adaptive 3-way quicksort in sorter ...................................................................... Patch Set 8: Code-Review+1 (1 comment) The change looks great! http://gerrit.cloudera.org:8080/#/c/18184/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18184/7//COMMIT_MSG@23 PS7, Line 23: +----------------------------------------------+----------------+--------------------+ : | Test | Original 2-way | Adaptive Quicksort | : +----------------------------------------------+----------------+--------------------+ : | select * order by l_linestatus, NDV=2: | 1 | 0.67 | : | select l_shipmode order by l_shipmode, NDV=7 | 1 | 0.42 | : | select * order by l_shipmode, NDV=7 | 1 | 0.57 | : | large NDV, unique data | > Thank you for the suggestion. Should I write the actual (average) execution I'm OK with the ratio. -- To view, visit http://gerrit.cloudera.org:8080/18184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81e7b36a04a43de3b83e6aeee49ca0943f0bf202 Gerrit-Change-Number: 18184 Gerrit-PatchSet: 8 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 11 Feb 2022 16:17:20 +0000 Gerrit-HasComments: Yes
