Gergely Fürnstáhl has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18215 )

Change subject: IMPALA-11113 and IMPALA-11114: fixed single_node_perf_run.py 
for TPCDS
......................................................................


Patch Set 4:

> Thanks for working on this! However, I still hit the following
 > error at the end of the run:
 >
 > Traceback (most recent call last):
 > File "bin/single_node_perf_run.py", line 359, in <module>
 > main()
 > File "bin/single_node_perf_run.py", line 349, in main
 > perf_ab_test(options, args)
 > File "bin/single_node_perf_run.py", line 267, in perf_ab_test
 > compare(temp_dir, hash_a, hash_b)
 > File "bin/single_node_perf_run.py", line 178, in compare
 > generate_profile_file(file_a, hash_a, base_dir)
 > File "bin/single_node_perf_run.py", line 194, in generate_profile_file
 > data = json.load(fid)
 > File 
 > "/home/quanlong/workspace/Impala/toolchain/toolchain-packages-gcc7.5.0/python-2.7.16/lib/python2.7/json/__init__.py",
 > line 291, in load
 > **kw)
 > File 
 > "/home/quanlong/workspace/Impala/toolchain/toolchain-packages-gcc7.5.0/python-2.7.16/lib/python2.7/json/__init__.py",
 > line 339, in loads
 > return _default_decoder.decode(s)
 > File 
 > "/home/quanlong/workspace/Impala/toolchain/toolchain-packages-gcc7.5.0/python-2.7.16/lib/python2.7/json/decoder.py",
 > line 364, in decode
 > obj, end = self.raw_decode(s, idx=_w(s, 0).end())
 > File 
 > "/home/quanlong/workspace/Impala/toolchain/toolchain-packages-gcc7.5.0/python-2.7.16/lib/python2.7/json/decoder.py",
 > line 380, in raw_decode
 > obj, end = self.scan_once(s, idx)
 > UnicodeDecodeError: 'utf8' codec can't decode byte 0xd4 in position
 > 1: invalid continuation byte
 >
 > Did I miss something?

Fixed it in patch set 4


--
To view, visit http://gerrit.cloudera.org:8080/18215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094763188a1f3ddf40b7140c65acf95918a6597f
Gerrit-Change-Number: 18215
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 14 Feb 2022 12:38:51 +0000
Gerrit-HasComments: No

Reply via email to