Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17785 )
Change subject: IMPALA-2019(part-4): Add UTF-8 support for case conversion functions ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/17785/10/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17785/10/be/src/exprs/string-functions-ir.cc@379 PS10, Line 379: uint8_t* result_ptr = result.ptr; This will be null if the allocation fails in the constructor. We should handle it similarly to the failure of resize() http://gerrit.cloudera.org:8080/#/c/17785/10/be/src/exprs/string-functions-ir.cc@383 PS10, Line 383: mbstate_t My understanding is that we should use the same mbstate_t during the processing of a string, as it's goal is to allow a conversion function to depend on the previous characters. This probably doesn't matter in utf8 though. http://gerrit.cloudera.org:8080/#/c/17785/10/be/src/exprs/string-functions-ir.cc@422 PS10, Line 422: context->has_error() We shouldn't need this, Resize() should return false on error. -- To view, visit http://gerrit.cloudera.org:8080/17785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I443e89d46f4638ce85664b021666bc4f03ee8abd Gerrit-Change-Number: 17785 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 14 Feb 2022 14:45:44 +0000 Gerrit-HasComments: Yes
