Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18099 )
Change subject: IMPALA-11049: Added expr analyzed check in 'SimplifyCastExprRule.java' ...................................................................... IMPALA-11049: Added expr analyzed check in 'SimplifyCastExprRule.java' We added a new expr rewrite rule 'SimplifyCastExprRule.java' in IMPALA-10836. If expr is not analyzed, this rewrite rule would throw an 'AnalysisException', this is due to 'orderByElements_' not been analyzed. We try to substitute order by elements when creating 'SortInfo', but caused some other problems. So we only add expr analyzed check in this rule to solve this problem. When adding other expr rewrite rules in the future, we should also add this check. Testing: - Added test cases in 'explain-level3.test' Change-Id: I2780e04a6d5a32e224cd0470cf6f166a832363ec Reviewed-on: http://gerrit.cloudera.org:8080/18099 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java M testdata/workloads/functional-query/queries/QueryTest/explain-level3.test 2 files changed, 62 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2780e04a6d5a32e224cd0470cf6f166a832363ec Gerrit-Change-Number: 18099 Gerrit-PatchSet: 10 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]>
