Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18226 )
Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests ...................................................................... Patch Set 1: (1 comment) The change looks good. I only had one ask about caching which was overlooked earlier. http://gerrit.cloudera.org:8080/#/c/18226/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/18226/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1036 PS1, Line 1036: TGetPartialCatalogObjectResponse resp = sendRequest(req); Currently we always send the request for every query. Can we add caching? See loadWithCaching() above. -- To view, visit http://gerrit.cloudera.org:8080/18226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e62a1fb9753ea1b022c7763047d9ccfd1d27d62 Gerrit-Change-Number: 18226 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:04:12 +0000 Gerrit-HasComments: Yes
