Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18191 )
Change subject: IMPALA-9433: Improved caching of HdfsFileHandles ...................................................................... Patch Set 22: (4 comments) http://gerrit.cloudera.org:8080/#/c/18191/22/be/src/runtime/io/handle-cache.h File be/src/runtime/io/handle-cache.h: http://gerrit.cloudera.org:8080/#/c/18191/22/be/src/runtime/io/handle-cache.h@117 PS22, Line 117: typedef LruMultiCache<std::pair<std::string, int64_t>, CachedHdfsFileHandle> CacheType; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/18191/22/be/src/util/lru-multi-cache.inline.h File be/src/util/lru-multi-cache.inline.h: http://gerrit.cloudera.org:8080/#/c/18191/22/be/src/util/lru-multi-cache.inline.h@132 PS22, Line 132: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18191/22/be/src/util/lru-multi-cache.inline.h@165 PS22, Line 165: auto container_it = container.emplace(container.end(), (*this), stored_key, container, std::forward<Args>(args)...); line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/18191/22/be/src/util/lru-multi-cache.inline.h@252 PS22, Line 252: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/18191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b5c5e9e2b5db2847ab88c41f667c9ca1b03d51a Gerrit-Change-Number: 18191 Gerrit-PatchSet: 22 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 24 Feb 2022 13:04:08 +0000 Gerrit-HasComments: Yes
