Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18191 )
Change subject: IMPALA-9433: Improved caching of HdfsFileHandles ...................................................................... Patch Set 25: Code-Review+1 (5 comments) The code looks awesome! http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/runtime/io/handle-cache.inline.h File be/src/runtime/io/handle-cache.inline.h: http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/runtime/io/handle-cache.inline.h@80 PS25, Line 80: if (cache_accessor_.Get()) : ImpaladMetrics::IO_MGR_NUM_FILE_HANDLES_OUTSTANDING->Increment(1L); nit: multi-line if stmt needs braces http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/util/lru-multi-cache.h File be/src/util/lru-multi-cache.h: http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/util/lru-multi-cache.h@53 PS25, Line 53: deigned nit: designed http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/util/lru-multi-cache.h@61 PS25, Line 61: nit: extra space http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/util/lru-multi-cache.h@74 PS25, Line 74: LRU order Please mention that least recently used elements are at the front. http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/util/lru-multi-cache.inline.h File be/src/util/lru-multi-cache.inline.h: http://gerrit.cloudera.org:8080/#/c/18191/25/be/src/util/lru-multi-cache.inline.h@214 PS25, Line 214: in_use Do we need 'in_use'? Can't we just use 'member_hook.is_linked()' instead? Maybe we just need a member function InUse(): return !member_hook.is_linked(); -- To view, visit http://gerrit.cloudera.org:8080/18191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b5c5e9e2b5db2847ab88c41f667c9ca1b03d51a Gerrit-Change-Number: 18191 Gerrit-PatchSet: 25 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 28 Feb 2022 11:21:41 +0000 Gerrit-HasComments: Yes
