Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py File tests/metadata/test_load.py: http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@131 PS2, Line 131: test_async_load nit: can you add a comment on what this test is verifying? Is the intent to just do a sanity check or to also verify that 2 different behaviors are expected from sync and async mode? http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@199 PS2, Line 199: exec_end_state == running_state or exec_end_state == finished_state was the original intent of this test to ensure different behaviour? that is, sync => finished state, async => running state ? Since sync can now return either, do we need to check any other metric or behavior to verify the difference between the two? -- To view, visit http://gerrit.cloudera.org:8080/18268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0 Gerrit-Change-Number: 18268 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 19:35:36 +0000 Gerrit-HasComments: Yes
