Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18240 )
Change subject: IMPALA-11053: Impala should be able to read migrated partitioned Iceberg tables ...................................................................... Patch Set 6: (4 comments) Thanks for the comments! PS6 is only a rebase. http://gerrit.cloudera.org:8080/#/c/18240/4/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: http://gerrit.cloudera.org:8080/#/c/18240/4/common/fbs/IcebergObjects.fbs@23 PS4, Line 23: // W > AVRO was added here as a possibility, but there is no test for it yet (if I Yeah, currently we don't support Iceberg tables with AVRO data files. I added some comments here instead of the commit message, as it is not too relevant for this CR. http://gerrit.cloudera.org:8080/#/c/18240/4/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_alltypes_part/metadata/v1.metadata.json File testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_alltypes_part/metadata/v1.metadata.json: http://gerrit.cloudera.org:8080/#/c/18240/4/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_alltypes_part/metadata/v1.metadata.json@1 PS4, Line 1: { > Can you add some minimal info about these files to https://github.com/apach Done http://gerrit.cloudera.org:8080/#/c/18240/4/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_alltypes_part/metadata/v1.metadata.json@148 PS4, Line 148: "engine.hive.enabled" : "true", : "MIGRATED_TO_ICEBERG" : "true", > Does the Hive we depend on support upgrading to Iceberg? Unfortunately the Hive we use in the dev environment doesn't have Iceberg support at all. We have IMPALA-10446 for adding interop tests later. These files were generated by a Hive that supports Iceberg and migration. http://gerrit.cloudera.org:8080/#/c/18240/4/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_legacy_partition_schema_evolution_orc/metadata/v1.metadata.json File testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_legacy_partition_schema_evolution_orc/metadata/v1.metadata.json: http://gerrit.cloudera.org:8080/#/c/18240/4/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_legacy_partition_schema_evolution_orc/metadata/v1.metadata.json@77 PS4, Line 77: "write.format.default" : "orc", > This name of the table contains "orc", but metadata files contain "parquet" Thanks for catching it, fixed it. -- To view, visit http://gerrit.cloudera.org:8080/18240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac11a02de709d43532056f71359c49d20c1be2b8 Gerrit-Change-Number: 18240 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 04 Mar 2022 11:31:29 +0000 Gerrit-HasComments: Yes
