Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18240 )
Change subject: IMPALA-11053: Impala should be able to read migrated partitioned Iceberg tables ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18240/4/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_legacy_partition_schema_evolution_orc/metadata/v1.metadata.json File testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_legacy_partition_schema_evolution_orc/metadata/v1.metadata.json: http://gerrit.cloudera.org:8080/#/c/18240/4/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_legacy_partition_schema_evolution_orc/metadata/v1.metadata.json@77 PS4, Line 77: "write.format.default" : "parquet", > I am a bit confused - shouldn't this also mean a change in the data files? Originally it was ORC when I created the table via Hive, but to make the Iceberg table usable in the tests I manually edit the JSON and AVRO metadata files. I think I created the metadata JSONs by copying from 'iceberg_legacy_partition_schema_evolution' which is Parquet. It didn't cause an issue because in functional_schema_template.sql we set the same table property in HMS to ORC. But to be sure I also verified that the data files are ORC, by using the 'file' utility. -- To view, visit http://gerrit.cloudera.org:8080/18240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac11a02de709d43532056f71359c49d20c1be2b8 Gerrit-Change-Number: 18240 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 04 Mar 2022 17:09:06 +0000 Gerrit-HasComments: Yes
