Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 )
Change subject: IMPALA-10992 Planner changes for estimate peak memory ...................................................................... Patch Set 17: Code-Review+1 Looks good to me. Can you check with Kurt if he wants to do another review, otherwise I can give a +2. Also, just curious if running all tests with 2 group sets caused a significant increase in core or exhaustive test run time. If it is quite significant, we might want to rethink that strategy -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 17 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Sat, 05 Mar 2022 02:45:13 +0000 Gerrit-HasComments: No
