Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG@9 PS1, Line 9: The test was getting skipped as it was not in exhaustive strategy, to fix that its : been moved to TestHmsIntegrationSanity(ImpalaTestSuite) class. Now there are two tests, : test_desc_json_tbl and test_desc_json_tbl_hive to check whether tables created in : impala can be described in hive and vice versa. nit: please fix the width to be 72. http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG@13 PS1, Line 13: the below commands: : impala-py.test --exploration=exhaustive : tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl : impala-py.test --exploration=exhaustive : tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl_hive nit: don't need to add these http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@108 PS1, Line 108: tables nit: JSON tables http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@109 PS1, Line 109: unique_table_impala nit: we can use a simpler table name, e.g. just as "json_tbl", and using it directly in the string. self.client.execute("create table {0}.json_tbl (x int) stored as jsonfile" .format(unique_database)) http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@116 PS1, Line 116: tables nit: JSON tables http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@117 PS1, Line 117: unique_table_hive nit: I'd prefer a simpler table name and use it directly in the string. E.g. self.run_stmt_in_hive("create table {0}.json_tbl (x int) stored as jsonfile" .format(unique_database)) self.client.execute("INVALIDATE METADATA {0}.json_tbl".format(unique_database)) -- To view, visit http://gerrit.cloudera.org:8080/18299 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1 Gerrit-Change-Number: 18299 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 10 Mar 2022 06:35:49 +0000 Gerrit-HasComments: Yes
