Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18314 )
Change subject: IMPALA-11176: Fix Memory leak in ClientCacheHelper ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18314/3/be/src/runtime/CMakeLists.txt File be/src/runtime/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18314/3/be/src/runtime/CMakeLists.txt@117 PS3, Line 117: ADD_UNIFIED_BE_LSAN_TEST(client-cache-test ClientCacheTest.*) > This enables leak sanitizer in the test. So can we skip checking the virtua Thanks for the advice. Tried the ASAN build, but failed to detect the leak. Maybe we need a newer compiler with newer ASAN http://gerrit.cloudera.org:8080/#/c/18314/3/be/src/runtime/client-cache-test.cc File be/src/runtime/client-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/18314/3/be/src/runtime/client-cache-test.cc@72 PS3, Line 72: const int vm_size_pos = 22; > Will this index be consistent across all linux distros? The index comes with the linux kernel, and I traced the file "https://github.com/torvalds/linux/blob/v3.4/fs/proc/array.c"; back to v3.4 2012, the index of vm size hasn't been changed since then. Maybe I can leave a comment in case the index might be changed and affect the test in the future. -- To view, visit http://gerrit.cloudera.org:8080/18314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bf3d7e7d897c89eb4538df5382ce3c590055b71 Gerrit-Change-Number: 18314 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 14 Mar 2022 18:16:58 +0000 Gerrit-HasComments: Yes
