Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18326
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern ...................................................................... IMPALA-11184: Use ProgramInvocationShortName for log glob pattern Impala uses FLAGS_log_filename as log symlink name and as part of the glob pattern during log rotation. The user will not set this flag in most cases, and it will default to google::ProgramInvocationShortName(). But if the user sets a custom value to this flag, the glob pattern will mistakenly target the symlink instead of the actual log files. This leads to a wrong behavior of DeleteOldLogs() and GetLatestCanonicalLogPath(). This patch replace FLAGS_log_filename with google::ProgramInvocationShortName() in glob pattern. Testing: - Pass simple-logger-test - Pass exhaustive test_breakpad.py::TestLogging Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa --- M be/src/common/init.cc M be/src/common/logging.cc M be/src/common/logging.h M tests/custom_cluster/test_breakpad.py 4 files changed, 28 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/18326/1 -- To view, visit http://gerrit.cloudera.org:8080/18326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa Gerrit-Change-Number: 18326 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
