Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18325 )
Change subject: IMPALA-11185: Reuse orc row batch in the scanner life-cycle ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18325/1/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18325/1/be/src/exec/hdfs-orc-scanner.cc@444 PS1, Line 444: orc_root_batch_ = tmp_row_reader->createRowBatch(state_->batch_size()); > The ORC lib will do this for us and reuse the buffers. Thanks for the explanations! -- To view, visit http://gerrit.cloudera.org:8080/18325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03887ed94af2ff03d67cd00c79375c734a75af62 Gerrit-Change-Number: 18325 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 17 Mar 2022 02:10:02 +0000 Gerrit-HasComments: Yes
