Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS ...................................................................... Patch Set 1: Code-Review+2 (4 comments) LGTM,just some nits. http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@7 PS1, Line 7: fails nit: fails -> failure http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@13 PS1, Line 13: then trigger the assertion. nit: then trigger -> triggers http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@16 PS1, Line 16: current process and contained in CentOS. Because the testcase nit: contained -> available http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@17 PS1, Line 17: doesn't involve in multithreading cases, it is okay to replace nit: 'in multithreading cases' -> multithreading -- To view, visit http://gerrit.cloudera.org:8080/18332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43 Gerrit-Change-Number: 18332 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 18 Mar 2022 00:58:24 +0000 Gerrit-HasComments: Yes
