Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18321 )
Change subject: IMPALA-11182: catch exceptions of orc::RowReader::createRowBatch ...................................................................... IMPALA-11182: catch exceptions of orc::RowReader::createRowBatch The ORC lib uses exceptions to report failures. We are missing exception handling in invoking orc::RowReader::createRowBatch which requires memory allocation and could raise exceptions when it fails. This patch simply adds a catch clause for it. To simplify the codes, a macro is added for catching the ORC exceptions with given message format. Tests: - run test_scanner_fuzz.py 20 times Change-Id: I76e36a238220e7bed1cbbdcb3fc7d35394bfa023 Reviewed-on: http://gerrit.cloudera.org:8080/18321 Reviewed-by: Csaba Ringhofer <csringho...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/hdfs-orc-scanner.cc 1 file changed, 28 insertions(+), 51 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/18321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I76e36a238220e7bed1cbbdcb3fc7d35394bfa023 Gerrit-Change-Number: 18321 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
