Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 )
Change subject: IMPALA-11038: Zipping unnest from view ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/18094/6/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/18094/6/common/thrift/PlanNodes.thrift@657 PS6, Line 657: 2: required i32 output_tuple_id Do I understand correctly that until now we were using the id of the item tuple desc of the collection_expr, but now the the id of this tuple can be different from the output tuple, while their layout will be the same, and no materialization actually occurs? http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java File fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java: http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@120 PS6, Line 120: // A view has already registered this TableRef. Let's find this view and do some It is registered here, right? https://github.com/apache/impala/blob/d3da875684598f0d734fb78a83751b72c00e9a02/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java#L281 Won't we also set sourceView in this case? https://github.com/apache/impala/blob/d3da875684598f0d734fb78a83751b72c00e9a02/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java#L235 http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@128 PS6, Line 128: processParentTableRefForZippingUnnest((InlineViewRef)parentTableRef); Is this really different to collectionExpr_ = collectionExpr_.trySubstitute(sourceView.getBaseTblSmap(), analyzer, true); at line 156 http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@521 PS6, Line 521: getExprSubsMapFromTableRef The name is a bit misleading, as it returns the baseTblSmap. -- To view, visit http://gerrit.cloudera.org:8080/18094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a Gerrit-Change-Number: 18094 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 22 Mar 2022 16:16:52 +0000 Gerrit-HasComments: Yes
