Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18336/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18336/8//COMMIT_MSG@22 PS8, Line 22: Testing: Ran e2e shell tests. http_socket_timeout_s is None by default - can you add a test where it is set to some value? Looked around for similar tests, and I have bumped into https://github.com/apache/impala/blob/ff21728838acd79d451959149f9adb8fdbf2798d/tests/shell/test_shell_commandline.py#L994 , which is skipped for hs2-http. Should the http_socket_timeout_s also solve the connection timeout issue? -- To view, visit http://gerrit.cloudera.org:8080/18336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94 Gerrit-Change-Number: 18336 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 29 Mar 2022 14:34:45 +0000 Gerrit-HasComments: Yes
