Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client ...................................................................... IMPALA-11126: impala-shell: Support configurable socket timeout for http client In 'hs2-http' mode, the socket timeout is None, which could cause hang like symptoms in case of a problematic remote server. Added support for configurable socket timeout using the new impala-shell config option '--http_socket_timeout_s'. If a reasonable timeout is set, impala-shell client can retry in case of connection issues, when possible. The default value of '--http_socket_timeout_s' is set to None, to prevent behavior changes for existing clients. More details on socket timeout here: https://docs.python.org/3/library/socket.html#socket-timeouts Testing: - Added tests for various timeout values in test_shell_commandline.py - Ran e2e shell tests. Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94 Reviewed-on: http://gerrit.cloudera.org:8080/18336 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Wenzhe Zhou <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> --- M shell/ImpalaHttpClient.py M shell/impala_client.py M shell/impala_shell.py M shell/impala_shell_config_defaults.py M shell/option_parser.py M tests/shell/test_shell_commandline.py 6 files changed, 70 insertions(+), 9 deletions(-) Approvals: Impala Public Jenkins: Verified Wenzhe Zhou: Looks good to me, but someone else must approve Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94 Gerrit-Change-Number: 18336 Gerrit-PatchSet: 13 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
