Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18242 )
Change subject: IMPALA-11115: Fix hitting DCHECK for brotli and deflate
compressions
......................................................................
IMPALA-11115: Fix hitting DCHECK for brotli and deflate compressions
The DCHECK was hit when an unsupported compression was included in
enum THdfsCompression but not in COMPRESSION_MAP.
Removed COMPRESSION_MAP as we can get the names from enum
THdfsCompression directly.
In release builds this didn't cause a crash, only a weird error
message ("INVALID" instead of the compression name).
Testing:
- added ee tests that try to insert with brotli and deflate
Change-Id: Ic38294b108ff3c4aa0b49117df95c5a1b8c60a4b
Reviewed-on: http://gerrit.cloudera.org:8080/18242
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/util/codec.cc
M common/thrift/CatalogObjects.thrift
M
testdata/workloads/functional-query/queries/QueryTest/insert_parquet_invalid_codec.test
M tests/query_test/test_insert_parquet.py
4 files changed, 17 insertions(+), 23 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic38294b108ff3c4aa0b49117df95c5a1b8c60a4b
Gerrit-Change-Number: 18242
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
