Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18383 )

Change subject: IMPALA-11023: Raise error when delete file is found in an 
Iceberg table
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18383/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:

http://gerrit.cloudera.org:8080/#/c/18383/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@566
PS2, Line 566:       throw new TableLoadingException("Data file list collection 
failed.");
I think it would be useful to include the original exception as well, i.e. use:

 TableLoadingException(String s, Throwable cause)



--
To view, visit http://gerrit.cloudera.org:8080/18383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e9cbf2424b27157883d551f73e728ab4ec6d21e
Gerrit-Change-Number: 18383
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tma...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Apr 2022 12:45:39 +0000
Gerrit-HasComments: Yes

Reply via email to