Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18387 )

Change subject: IMPALA-11227: FE OOM in 
TestParquetBloomFilter.test_fallback_from_dict_if_no_bloom_tbl_props
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18387/1/tests/query_test/test_parquet_bloom_filter.py
File tests/query_test/test_parquet_bloom_filter.py:

http://gerrit.cloudera.org:8080/#/c/18387/1/tests/query_test/test_parquet_bloom_filter.py@214
PS1, Line 214: bl_create_stmt = \
             :         'create table {db}.{tbl} ({col_name} BIGINT) stored as 
textfile' .forma
> optional: I think that this could be made simpler by using an existing tabl
Ah, this is a cleaner approach! Maybe need an ORDER BY clause as well.



--
To view, visit http://gerrit.cloudera.org:8080/18387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I923cc9ba4b6829a2f15e93365f2849b89248598b
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Thu, 07 Apr 2022 01:58:56 +0000
Gerrit-HasComments: Yes

Reply via email to