Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17595 )
Change subject: IMPALA-10723: Treat materialized view as a table instead of a view ...................................................................... Patch Set 14: > Patch Set 13: > > (1 comment) > > > Patch Set 13: Verified-1 > > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8026/ > > I take a look at file-list-begin-1.log in one of the build. There are no > files under the functional_parquet.alltypes_transactional and > functional_parquet.jointbl_transactional tables. Neither can I find > statements loading these two tables in > logs/data_loading/sql/functional/load-functional-query-exhaustive-impala-generated-parquet-none-none.sql. > > Note that these tables under the functional db is ok (non-empty). However, I > can't find the rebuild statement on the MV in > logs/data_loading/sql/functional/load-functional-query-exhaustive-hive-generated-text-none-none.sql. In the latest patch set (PS14) I made a few changes: 1. For the new transactional tables and materialized views, I am now doing 'STORED AS {file_format}'. Previously this was doing STORED AS PARQUET. 2. In datasets/functional/schema_constraints.csv, I am restricting the MVs and the source tables to the ORC format. The reason is that ALTER MATERIALIZED VIEW ... REBUILD is not rebuilding the MV if the format is Parquet but does it for ORC. The log file shows the SQL command to do the rebuild is issued but the Tez tasks never get spawned and no error is produced. On the other hand for ORC, I do see the Tez tasks. The MV rebuild is supposed to work for both ORC and Parquet but perhaps it is not supported in the Hive version in the toolchain. I can look into this as a follow-up. 3. There was an interesting side-effect of the 2 MVs. Since they both had the exact same SQL definition, what would happen is that when creating the second MV mv2_alltypes_jointbl, if the first MV mv1_alltypes_jointbl had already been created, the optimizer would do a rewrite. This is not the intent, so I have modified the mv2_alltypes_jointbl definition slightly. -- To view, visit http://gerrit.cloudera.org:8080/17595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff Gerrit-Change-Number: 17595 Gerrit-PatchSet: 14 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 11 Apr 2022 04:47:36 +0000 Gerrit-HasComments: No
