Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18403 )
Change subject: IMPALA-10839: NULL values are displayed on a wrong level for nested structs (ORC) ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18403/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18403/2//COMMIT_MSG@12 PS2, Line 12: select id, outer_struct.inner_struct3 from : functional_orc_def.complextypes_nested_structs where id >= 4 Can you add some tests like this? testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list.test http://gerrit.cloudera.org:8080/#/c/18403/2/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/18403/2/be/src/exec/orc-column-readers.cc@52 PS2, Line 52: scanner->slot_to_col_id_[slot_desc] == node->getColumnId(); nit: +2 indentation -- To view, visit http://gerrit.cloudera.org:8080/18403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff5034e7bdf39c036aecc491fbd324e29150f040 Gerrit-Change-Number: 18403 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 15:03:17 +0000 Gerrit-HasComments: Yes
