Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18421 )
Change subject: IMPALA-11247: Test script changes for materialized views ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18421/1/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/18421/1/testdata/datasets/functional/functional_schema_template.sql@2562 PS1, Line 2562: INSERT OVERWRITE TABLE {db_name}{db_suffix}.{table_name} PARTITION (year, month) > Does this work for parquet? Or should we remove these? I see..I didn't know that the default mode for functional_orc_def.alltypes and functional_orc_def.jointbl is full-ACID. It makes sense to use those. I have modified the MV definitions accordingly and removed the references. to alltypes_transactional and jointbl_transactional from both files. Regarding Parquet, my original intent was to have source tables in both ORC and Parquet formats since I only needed insert-only transactional tables (no row level updates are being done to any of the source). However, there is some problem doing an MV rebuild if the source table is insert-only especially when done through the test load script. So, for now let's restrict the test case to ORC full-ACID. -- To view, visit http://gerrit.cloudera.org:8080/18421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I349faa0ad36ec8ca6f574f7f92d9a32fb7d0d344 Gerrit-Change-Number: 18421 Gerrit-PatchSet: 2 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sun, 17 Apr 2022 02:35:46 +0000 Gerrit-HasComments: Yes
